Skip to content

fix: support for high contrast #300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2025
Merged

fix: support for high contrast #300

merged 1 commit into from
Oct 24, 2025

Conversation

@mcoker
Copy link
Contributor

@mcoker mcoker commented Oct 15, 2025 •
edited
Loading

What

Closes #298

Preview link: https://react-topology-pr-topology-300.surge.sh/

To enable high contrast, you have to do it manually by adding the class pf-v6-theme-high-contrast to the document's <html> element.

Description

  • Updates default group stroke color to border--color--main--default
  • Updates default group stroke width to border--width--extra-strong (3px)
    • I didn't see this called out explicitly (unless I missed it), but seems implied by the notes in figma to make the borders (3px default, x-strong + 1 hover, x-strong + 2 selected)
  • Updates group hover stroke width to 4px in HC only
  • Updates group selected stroke width to 5px in HC only
  • Updates group hover + selected stroke width to 4px in HC only
  • Updates edge stroke from #707070 to border--color--on-secondary

Also updates the PF packages to latest prerelease, I imagine we'll remove that and bump to 6.4.0 here or in a separate PR once the PF release lands.

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

@patternfly-build
Copy link

patternfly-build commented Oct 15, 2025 •
edited
Loading

Preview: https://react-topology-pr-topology-300.surge.sh

@mcoker
Copy link
Contributor Author

mcoker commented Oct 15, 2025

@lboehling - tagging you here since I can't add you as a reviewer.

@mcoker mcoker mentioned this pull request Oct 15, 2025
Open
24 tasks
@lboehling
Copy link

lboehling commented Oct 21, 2025

@lboehling - tagging you here since I can't add you as a reviewer.

approved!

@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Oct 23, 2025

@mcoker Please run yarn test -u to update the snapshot in order for tests to pass.

@mcoker
Copy link
Contributor Author

mcoker commented Oct 23, 2025

@jeff-phillips-18 I rebased, then ran yarn test -u, and got this message

Internal Error: @patternfly/react-topology-root@workspace:.: This package doesn't seem to be present in your lockfile; run "yarn install" to update the lockfile
    at HT.getCandidates (/Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:204:4607)
    at rm.getCandidates (/Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:141:1311)
    at /Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:209:8420
    at qE (/Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:140:45033)
    at mt (/Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:209:8400)
    at async Promise.allSettled (index 0)
    at async Uu (/Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:140:44361)
    at async /Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:209:9166
    at async ki.startProgressPromise (/Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:140:129201)
    at async t.resolveEverything (/Users/cmichael/.cache/node/corepack/v1/yarn/4.10.3/yarn.js:209:7138)

After running yarn install, it lists these files as modified

  modified:   package.json
  modified:   packages/demo-app-ts/package.json
  modified:   packages/module/package.json
  modified:   yarn.lock

And this is the diff - https://paste.centos.org/view/af5ef62e

Should I check all of those files in? Or just the updated test file after updating tests?

@jeff-phillips-18
Copy link
Member

jeff-phillips-18 commented Oct 23, 2025

@mcoker If you rebase again those changes should go away (and I think the snapshot is updated there as well)

@mcoker
Copy link
Contributor Author

mcoker commented Oct 23, 2025

@jeff-phillips-18 should be good now

@jeff-phillips-18 jeff-phillips-18 merged commit 8915c7d into patternfly:main Oct 24, 2025
8 checks passed
@github-actions
Copy link

github-actions bot commented Oct 24, 2025

🎉 This PR is included in version 6.5.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jeff-phillips-18 jeff-phillips-18 jeff-phillips-18 approved these changes

@andrew-ronaldson andrew-ronaldson Awaiting requested review from andrew-ronaldson

Assignees

No one assigned

Labels

released on @prerelease

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

High contrast: Update tokens to enable high contrast theme

4 participants

@mcoker @patternfly-build @lboehling @jeff-phillips-18